Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return symlinked path itself if points to the root of a git repo #7561

Draft
wants to merge 1 commit into
base: maint
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Feb 12, 2024

Ref: #7438 (comment)

@yarikoptic yarikoptic marked this pull request as draft February 12, 2024 16:52
@yarikoptic yarikoptic added the semver-patch Increment the patch version when merged label Feb 12, 2024
@yarikoptic
Copy link
Member Author

test_bf1886 is effected on various setups -- yet to check...
        # need to use absolute paths
        with chpwd(op.join(parent.path, 'subdir', 'subsubdir')):
            save([op.join(parent.path, 'sub3'),
                  op.join(parent.path, 'subdir', 'subsubdir', 'upup3')])
>       assert_repo_status(parent.path)
..\datalad\core\local\tests\test_save.py:357: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
..\datalad\tests\utils_pytest.py:1664: in assert_repo_status
    eq_(state_files, oktobefound,
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
first = [WindowsPath('C:/DLTMP/datalad_temp_xtr1ag07/sub3'), WindowsPath('C:/DLTMP/datalad_temp_xtr1ag07/subdir/subsubdir/upup3')]
second = []
msg = 'unexpected content of state "untracked": [WindowsPath(\'C:/DLTMP/datalad_temp_xtr1ag07/sub3\'), WindowsPath(\'C:/DLTMP/datalad_temp_xtr1ag07/subdir/subsubdir/upup3\')] != []'
    def assert_equal(first, second, msg=None):
        if msg is None:
            assert first == second
        else:
>           assert first == second, msg
E           AssertionError: unexpected content of state "untracked": [WindowsPath('C:/DLTMP/datalad_temp_xtr1ag07/sub3'), WindowsPath('C:/DLTMP/datalad_temp_xtr1ag07/subdir/subsubdir/upup3')] != []
E           assert [WindowsPath(...ubdir/upup3')] == []
E             
E             Left contains 2 more items, first extra item: WindowsPath('C:/DLTMP/datalad_temp_xtr1ag07/sub3')
E             
E             Full diff:
E             - []
E             + [
E             +     WindowsPath('C:/DLTMP/datalad_temp_xtr1ag07/sub3'),
E             +     WindowsPath('C:/DLTMP/datalad_temp_xtr1ag07/subdir/subsubdir/upup3'),
E             + ]
..\datalad\tests\utils_pytest.py:82: AssertionError
---------- coverage: platform win32, python 3.9.13-final-0 -----------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant