fix(webpack): exclude files starting with _ from require.context (NativeScript#9596)

rigor789 · web-flow · commit 99298331c82c · 2021-10-06T12:49:47.000+02:00
diff --git a/packages/webpack5/__tests__/configuration/__snapshots__/javascript.spec.ts.snap b/packages/webpack5/__tests__/configuration/__snapshots__/javascript.spec.ts.snap
@@ -318,6 +318,10 @@ exports[`javascript configuration for android 1`] = `
       {
         '__jest__/src/__@nativescript_webpack_virtual_entry_javascript__': '// VIRTUAL ENTRY START\\\\nrequire(\\\\'@nativescript/core/bundle-entry-points\\\\')\\\\nconst context = require.context(\\"~/\\", /* deep: */ true, /* filter: */ /.(xml|js|s?css)$/);\\\\nglobal.registerWebpackModules(context);\\\\n// VIRTUAL ENTRY END'
       }
+    ),
+    /* config.plugin('ContextExclusionPlugin|exclude_files') */
+    new ContextExclusionPlugin(
+      /\\\\b_.+\\\\./
     )
   ],
   entry: {
@@ -651,6 +655,10 @@ exports[`javascript configuration for ios 1`] = `
       {
         '__jest__/src/__@nativescript_webpack_virtual_entry_javascript__': '// VIRTUAL ENTRY START\\\\nrequire(\\\\'@nativescript/core/bundle-entry-points\\\\')\\\\nconst context = require.context(\\"~/\\", /* deep: */ true, /* filter: */ /.(xml|js|s?css)$/);\\\\nglobal.registerWebpackModules(context);\\\\n// VIRTUAL ENTRY END'
       }
+    ),
+    /* config.plugin('ContextExclusionPlugin|exclude_files') */
+    new ContextExclusionPlugin(
+      /\\\\b_.+\\\\./
     )
   ],
   entry: {
diff --git a/packages/webpack5/__tests__/configuration/__snapshots__/typescript.spec.ts.snap b/packages/webpack5/__tests__/configuration/__snapshots__/typescript.spec.ts.snap
@@ -318,6 +318,10 @@ exports[`typescript configuration for android 1`] = `
       {
         '__jest__/src/__@nativescript_webpack_virtual_entry_typescript__': '// VIRTUAL ENTRY START\\\\nrequire(\\\\'@nativescript/core/bundle-entry-points\\\\')\\\\nconst context = require.context(\\"~/\\", /* deep: */ true, /* filter: */ /\\\\\\\\.(xml|js|(?<!\\\\\\\\.d\\\\\\\\.)ts|s?css)$/);\\\\nglobal.registerWebpackModules(context);\\\\n// VIRTUAL ENTRY END'
       }
+    ),
+    /* config.plugin('ContextExclusionPlugin|exclude_files') */
+    new ContextExclusionPlugin(
+      /\\\\b_.+\\\\./
     )
   ],
   entry: {
@@ -651,6 +655,10 @@ exports[`typescript configuration for ios 1`] = `
       {
         '__jest__/src/__@nativescript_webpack_virtual_entry_typescript__': '// VIRTUAL ENTRY START\\\\nrequire(\\\\'@nativescript/core/bundle-entry-points\\\\')\\\\nconst context = require.context(\\"~/\\", /* deep: */ true, /* filter: */ /\\\\\\\\.(xml|js|(?<!\\\\\\\\.d\\\\\\\\.)ts|s?css)$/);\\\\nglobal.registerWebpackModules(context);\\\\n// VIRTUAL ENTRY END'
       }
+    ),
+    /* config.plugin('ContextExclusionPlugin|exclude_files') */
+    new ContextExclusionPlugin(
+      /\\\\b_.+\\\\./
     )
   ],
   entry: {
diff --git a/packages/webpack5/src/configuration/javascript.ts b/packages/webpack5/src/configuration/javascript.ts
@@ -4,6 +4,7 @@ import { getEntryPath, getEntryDirPath } from '../helpers/platform';
 import { addVirtualEntry } from '../helpers/virtualModules';
 import { chainedSetAddAfter } from '../helpers/chain';
 import { env as _env, IWebpackEnv } from '../index';
+import { ContextExclusionPlugin } from 'webpack';
 import base from './base';
 
 export default function (config: Config, env: IWebpackEnv = _env): Config {
@@ -22,6 +23,11 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
 	`
 	);
 
+	// exclude files starting with _ from require.context
+	config
+		.plugin(`ContextExclusionPlugin|exclude_files`)
+		.use(ContextExclusionPlugin, [/\b_.+\./]);
+
 	chainedSetAddAfter(
 		config.entry('bundle'),
 		'@nativescript/core/globals/index.js',
diff --git a/packages/webpack5/src/configuration/typescript.ts b/packages/webpack5/src/configuration/typescript.ts
@@ -4,6 +4,7 @@ import { getEntryDirPath, getEntryPath } from '../helpers/platform';
 import { addVirtualEntry } from '../helpers/virtualModules';
 import { chainedSetAddAfter } from '../helpers/chain';
 import { env as _env, IWebpackEnv } from '../index';
+import { ContextExclusionPlugin } from 'webpack';
 import base from './base';
 
 export default function (config: Config, env: IWebpackEnv = _env): Config {
@@ -22,6 +23,11 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
 	`
 	);
 
+	// exclude files starting with _ from require.context
+	config
+		.plugin(`ContextExclusionPlugin|exclude_files`)
+		.use(ContextExclusionPlugin, [/\b_.+\./]);
+
 	chainedSetAddAfter(
 		config.entry('bundle'),
 		'@nativescript/core/globals/index.js',

Original file line number	Diff line number	Diff line change
@@ -318,6 +318,10 @@ exports[`javascript configuration for android 1`] = `
`318`	`318`	`{`
`319`	`319`	`'__jest__/src/__@nativescript_webpack_virtual_entry_javascript__': '// VIRTUAL ENTRY START\\\\nrequire(\\\\'@nativescript/core/bundle-entry-points\\\\')\\\\nconst context = require.context(\\"~/\\", /* deep: / true, / filter: */ /.(xml\|js\|s?css)$/);\\\\nglobal.registerWebpackModules(context);\\\\n// VIRTUAL ENTRY END'`
`320`	`320`	`}`
	`321`	`+ ),`
	`322`	`+ /* config.plugin('ContextExclusionPlugin\|exclude_files') */`
	`323`	`+ new ContextExclusionPlugin(`
	`324`	`+ /\\\\b_.+\\\\./`
`321`	`325`	`)`
`322`	`326`	`],`
`323`	`327`	`entry: {`
@@ -651,6 +655,10 @@ exports[`javascript configuration for ios 1`] = `
`651`	`655`	`{`
`652`	`656`	`'__jest__/src/__@nativescript_webpack_virtual_entry_javascript__': '// VIRTUAL ENTRY START\\\\nrequire(\\\\'@nativescript/core/bundle-entry-points\\\\')\\\\nconst context = require.context(\\"~/\\", /* deep: / true, / filter: */ /.(xml\|js\|s?css)$/);\\\\nglobal.registerWebpackModules(context);\\\\n// VIRTUAL ENTRY END'`
`653`	`657`	`}`
	`658`	`+ ),`
	`659`	`+ /* config.plugin('ContextExclusionPlugin\|exclude_files') */`
	`660`	`+ new ContextExclusionPlugin(`
	`661`	`+ /\\\\b_.+\\\\./`
`654`	`662`	`)`
`655`	`663`	`],`
`656`	`664`	`entry: {`
Original file line number	Diff line number	Diff line change
@@ -318,6 +318,10 @@ exports[`typescript configuration for android 1`] = `
`318`	`318`	`{`
`319`	`319`	`'__jest__/src/__@nativescript_webpack_virtual_entry_typescript__': '// VIRTUAL ENTRY START\\\\nrequire(\\\\'@nativescript/core/bundle-entry-points\\\\')\\\\nconst context = require.context(\\"~/\\", /* deep: / true, / filter: */ /\\\\\\\\.(xml\|js\|(?<!\\\\\\\\.d\\\\\\\\.)ts\|s?css)$/);\\\\nglobal.registerWebpackModules(context);\\\\n// VIRTUAL ENTRY END'`
`320`	`320`	`}`
	`321`	`+ ),`
	`322`	`+ /* config.plugin('ContextExclusionPlugin\|exclude_files') */`
	`323`	`+ new ContextExclusionPlugin(`
	`324`	`+ /\\\\b_.+\\\\./`
`321`	`325`	`)`
`322`	`326`	`],`
`323`	`327`	`entry: {`
@@ -651,6 +655,10 @@ exports[`typescript configuration for ios 1`] = `
`651`	`655`	`{`
`652`	`656`	`'__jest__/src/__@nativescript_webpack_virtual_entry_typescript__': '// VIRTUAL ENTRY START\\\\nrequire(\\\\'@nativescript/core/bundle-entry-points\\\\')\\\\nconst context = require.context(\\"~/\\", /* deep: / true, / filter: */ /\\\\\\\\.(xml\|js\|(?<!\\\\\\\\.d\\\\\\\\.)ts\|s?css)$/);\\\\nglobal.registerWebpackModules(context);\\\\n// VIRTUAL ENTRY END'`
`653`	`657`	`}`
	`658`	`+ ),`
	`659`	`+ /* config.plugin('ContextExclusionPlugin\|exclude_files') */`
	`660`	`+ new ContextExclusionPlugin(`
	`661`	`+ /\\\\b_.+\\\\./`
`654`	`662`	`)`
`655`	`663`	`],`
`656`	`664`	`entry: {`