Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CJSX #1009

Open
alangpierce opened this issue May 2, 2017 · 2 comments
Open

Add support for CJSX #1009

alangpierce opened this issue May 2, 2017 · 2 comments
Assignees
@alangpierce
Labels
enhancement

Comments

@alangpierce
Copy link
Member

Mentioned in #1007 and also in this blog post:
https://blog.bugsnag.com/converting-a-large-react-codebase-from-coffeescript-to-es6/

It would be cool to add native support for CJSX. This means it would be some new AST node types and the JSX would be patched directly to JSX within JavaScript.

This is just a tracking bug, and it would need some further investigation:

  • See how reasonable it is to process CJSX in the first place. From my initial reading, looks like it may just be a rewriter that emits CoffeeScript, which means a unified AST form could be really hard.
  • Find an open source project using .cjsx to use as a test case.
@alangpierce alangpierce self-assigned this Feb 28, 2018
alangpierce added a commit to alangpierce/coffee-lex that referenced this issue Mar 11, 2018
@alangpierce
feat: add an initial working version of CSX tokenization
42fb8b4 
Progress toward decaffeinate/decaffeinate#1009

This is hopefully the most difficult part of properly supporting CSX/JSX in
decaffeinate. It's necessary for coffee-lex to be CSX-aware so that we can get
proper token information within CSX interpolations.

BREAKING CHANGE: Some obscure cases were valid expressions before but are now
treated as CSX. This should match the equivalent minor breaking change in CS2.
@alangpierce alangpierce mentioned this issue Mar 11, 2018
Merged
eventualbuddha pushed a commit to alangpierce/coffee-lex that referenced this issue Mar 11, 2018
@alangpierce @eventualbuddha
feat: add an initial working version of CSX tokenization
337109c 
Progress toward decaffeinate/decaffeinate#1009

This is hopefully the most difficult part of properly supporting CSX/JSX in
decaffeinate. It's necessary for coffee-lex to be CSX-aware so that we can get
proper token information within CSX interpolations.

BREAKING CHANGE: Some obscure cases were valid expressions before but are now
treated as CSX. This should match the equivalent minor breaking change in CS2.
eventualbuddha pushed a commit to alangpierce/coffee-lex that referenced this issue Mar 11, 2018
@alangpierce @eventualbuddha
feat: add an initial working version of CSX tokenization
6533819 
Progress toward decaffeinate/decaffeinate#1009

This is hopefully the most difficult part of properly supporting CSX/JSX in
decaffeinate. It's necessary for coffee-lex to be CSX-aware so that we can get
proper token information within CSX interpolations.

BREAKING CHANGE: Some obscure cases were valid expressions before but are now
treated as CSX. This should match the equivalent minor breaking change in CS2.
alangpierce added a commit to alangpierce/coffee-lex that referenced this issue Mar 11, 2018
@alangpierce
feat: add an initial working version of CSX tokenization
393b882 
Progress toward decaffeinate/decaffeinate#1009

This is hopefully the most difficult part of properly supporting CSX/JSX in
decaffeinate. It's necessary for coffee-lex to be CSX-aware so that we can get
proper token information within CSX interpolations.

BREAKING CHANGE: Some obscure cases were valid expressions before but are now
treated as CSX. This should match the equivalent minor breaking change in CS2.
This change also drops node 4 support.
alangpierce added a commit to alangpierce/coffee-lex that referenced this issue Mar 11, 2018
@alangpierce
feat: add an initial working version of CSX tokenization
809afae 
Progress toward decaffeinate/decaffeinate#1009

This is hopefully the most difficult part of properly supporting CSX/JSX in
decaffeinate. It's necessary for coffee-lex to be CSX-aware so that we can get
proper token information within CSX interpolations.

BREAKING CHANGE: Some obscure cases were valid expressions before but are now
treated as CSX. This should match the equivalent minor breaking change in CS2.
This change also drops node 4 support.
alangpierce added a commit to decaffeinate/coffee-lex that referenced this issue Mar 11, 2018
@alangpierce
feat: add an initial working version of CSX tokenization (#153)
a6cc300 
Progress toward decaffeinate/decaffeinate#1009

This is hopefully the most difficult part of properly supporting CSX/JSX in
decaffeinate. It's necessary for coffee-lex to be CSX-aware so that we can get
proper token information within CSX interpolations.

BREAKING CHANGE: Some obscure cases were valid expressions before but are now
treated as CSX. This should match the equivalent minor breaking change in CS2.
This change also drops node 4 support.
@a-x-
Copy link

a-x- commented Feb 8, 2019

Hey, @alangpierce,
we're dream about it too
but is it frozen now?

@a-x-
Copy link

a-x- commented Feb 8, 2019

Seems, there is some wrapper tool: depercolator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alangpierce alangpierce

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alangpierce @a-x-