Skip to content

Follow up flatbuffers (frontend backwards compat run) #10192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

agibsonccc
Copy link
Contributor

What changes were proposed in this pull request?

Basic clean up of typescript flatbuffers + small test run for backwar…ds compatibility
Also removes some out of date tests discovered during the process of trying to run them.
May still find issues but it seems like we can still load models from the old version.

How was this patch tested?

Manually run test. This ran some basic flatbuffers tests to check for backwards compatibility and cleans up some front end dependency issues with the samediff ui.

Quick checklist

The following checklist helps ensure your PR is complete:

  • [X ] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
  • [ X] Reviewed the Contributing Guidelines and followed the steps within.
  • [X ] Created tests for any significant new code additions.
  • [ X] Relevant tests for your changes are passing.

@agibsonccc agibsonccc requested a review from treo February 21, 2025 11:29
@agibsonccc agibsonccc merged commit 7ebc9ae into master Feb 21, 2025
1 check passed
@agibsonccc agibsonccc deleted the ag_flatbuffers_2 branch February 21, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants