Skip to content

fix pyMethodDef layout #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix pyMethodDef layout #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57aebe9
fix pyMethodDef layout
sigmaSd Jul 14, 2024
579b3b2
comment
sigmaSd Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/python.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,9 @@ export class PyObject {
}
return new PyObject(list);
} else if (v instanceof Callback) {
const pyMethodDef = new Uint8Array(8 + 8 + 4 + 8);
// https://docs.python.org/3/c-api/structures.html#c.PyMethodDef
// there are extra 4 bytes of padding after ml_flags field
const pyMethodDef = new Uint8Array(8 + 8 + 4 + 4 + 8);
const view = new DataView(pyMethodDef.buffer);
const LE =
new Uint8Array(new Uint32Array([0x12345678]).buffer)[0] !== 0x7;
Expand All @@ -471,7 +473,7 @@ export class PyObject {
);
view.setInt32(16, 0x1 | 0x2, LE);
view.setBigUint64(
20,
24,
BigInt(Deno.UnsafePointer.value(Deno.UnsafePointer.of(nameBuf)!)),
LE,
);
Expand Down