Symfony flex support #1440

zorn-v · 2017-12-08T04:03:47Z

Q	A
Bug fix?	No
New feature?	Yes
BC breaks?	No
Deprecations?	No
Fixed tickets	#1437

Cryde · 2018-01-04T06:17:50Z

recipe/symfony-flex.php

+set('clear_paths', []);
+
+// Symfony shared dirs
+set('shared_dirs', ['var/log', 'var/sessions']);


Also nope. var/log, not var/logs

The default directory for logs is var/log (since 3.4)

Cryde · 2018-01-04T06:17:55Z

recipe/symfony-flex.php

+set('shared_dirs', ['var/log', 'var/sessions']);
+
+// Symfony writable dirs
+set('writable_dirs', ['var/cache', 'var/log', 'var/sessions']);


Also var/log

Cryde · 2018-01-04T06:20:29Z

recipe/symfony-flex.php

+// Environment vars
+set('env', function () {
+    return [
+        'APP_ENV' => get('symfony_env')


We should probably add documentation to tell the user to put "symfony_env" in it's host.yml

Before it was SYMFONY_ENV https://github.com/deployphp/deployer/blob/master/recipe/symfony.php#L41
But it not for flex

Maybe:

// Environment vars set('env', function () { return [ 'SYMFONY_ENV' => get('symfony_env'), 'APP_ENV' => get('symfony_env'), ]; });

I can not set environment variables on my server so Dotenv is also included in the production environment. There were complications. I noticed that setting APP_ENV disables reading the .env file, therefore I set only symfony_env to have all commands with --env={{symfony_env}} option. My env for now:

// Environment vars set('env', []);

Hmm. Maybe you are right and your solution is much better than my hacky workaround #1440 (comment)
AFAIR composer does not account --env=
Will test, and change it if all works fine.

Cryde · 2018-01-04T06:21:23Z

recipe/symfony-flex.php

+ */
+
+//No need to clear anything
+set('clear_paths', []);


It's already define in symfony3 recipe :)

Nope https://github.com/deployphp/deployer/blob/master/recipe/symfony.php#L30

My bad ! Sorry !

Cryde · 2018-01-04T06:34:52Z

recipe/symfony-flex.php

+set('writable_dirs', ['var/cache', 'var/log', 'var/sessions']);
+
+//File for DotEnv if not using env vars
+set('shared_files', ['.env']);


And btw the dotenv component is in require-dev when we do a fresh install ... I'm not sure if it's a good idea

Actually there is a conversation on moving dotenv to require symfony/symfony#25643

Cryde · 2018-01-04T06:39:49Z

Another tought : what about commands launched that require DB access (in prod mode) ? 🤔
Like migration for instance

zorn-v · 2018-01-05T05:28:13Z

And now think about is it ENV vars really good for deploy ?
But you can set env from some local file that not under version control anyway... And set that vars on remote somehow ;)

antonmedv · 2018-01-05T05:41:55Z

@zorn-v no, then don't. 😄

I really want to combine all symfony recipes into one in next v7. Let's merge it now for v6 although.

Can you add init script for symfony flex?

zorn-v · 2018-01-05T06:11:33Z

What do you mean by 'init script' ?

antonmedv · 2018-01-05T06:13:21Z

https://github.com/deployphp/deployer/tree/master/src/Initializer/Template

zorn-v · 2018-01-05T06:23:02Z

Yes, I already understand what do you mean 😄
How do you think, do it with accounting of DotEnv in prod ?

"Best practice" (env vars) not so conveniently... You need to set params in 3 different places.

In deployer
For console commands on remote
For web server on remote

antonmedv · 2018-01-05T06:36:37Z

Let's leave it for user? 😁

Trim every thing related of setting params from recipe and add comment to init template about for to start using .env, if user want of cause :))

I like .env file.

zorn-v · 2018-01-05T07:04:53Z

What do you think ?
Yes there need some workaround for composer install (coz scripts in composer.json)

antonmedv · 2018-01-05T07:08:02Z

src/Initializer/Template/SymfonyFlexTemplate.php

+before('deploy:symlink', 'database:migrate');
+
+//If you don't use DotEnv in prod just wipe it out
+task('clear:env', function () {


What purpose of this task?

DotEnv does not run at all if APP_ENV is set https://github.com/symfony/recipes/blob/master/symfony/framework-bundle/3.3/public/index.php#L11
Same in console commands
But it need for composer install (scripts can not load deps in require-dev if APP_ENV not 'prod')

I think it's better not to hack APP_ENV but unstead write comment what user need to move dotenv to require section.

But this task needed exactly in order if DotEnv in require ;)
One more time - DotEnv does not run if APP_ENV is set.
If you don't set it in env, composer install will fail.

Yes I know that is hack. But I think that I can not convince community to change !isset($_SERVER['APP_ENV']) to file_exists(__DIR__.'/../.env')

gander · 2018-01-09T08:33:35Z

recipe/symfony-flex.php

+set('web_dir', 'public');
+
+// Assets
+set('assets', ['public/css', 'public/images', 'public/js']);


set('assets', ['{{web_dir}}/css', '{{web_dir}}/images', '{{web_dir}}/js']);

antonmedv · 2018-01-15T05:53:48Z

Okay, problem now with:

if (!isset($_SERVER['APP_ENV'])) {
    if (!class_exists(Dotenv::class)) {
        throw new \RuntimeException('APP_ENV environment variable is not defined. You need to define environment variables for configuration or add "symfony/dotenv" as a Composer dependency to load variables from a .env file.');
    }
    (new Dotenv())->load(__DIR__.'/../.env');
}

I think we just need mention not to refactor to:

(new Dotenv())->load(__DIR__.'/../.env');

Cryde · 2018-01-27T07:27:12Z

Any news on this ?

antonmedv · 2018-01-27T07:48:52Z

Need to figure out how to properly handle env. Soon will create my recipe.

zorn-v · 2018-03-03T09:35:01Z

Any news, suggestions. Maybe need some recomendations ?

zorn-v · 2018-03-03T09:39:13Z

In last project I just installed apache-pack and put SetEnv in .htaccess (with preg_replace with same vars for DB in deployer)
ENV for deployer only needed for doctrine migrations (except APP_ENV=prod). Maybe think in this direction ?

antonmedv · 2018-03-04T10:49:54Z

I’m thinking on suggesting of using doyens for prod. This will require APP_ENV rrmoval

antonmedv · 2018-03-05T13:26:29Z

Done in 443de26

zorn-v · 2018-03-05T14:57:22Z

Maybe var/sessions also in shared ?
And default writable_mode no so good BTW.

antonmedv · 2018-03-05T15:04:40Z

var stands for variable?

antonmedv · 2018-03-05T15:05:14Z

var/sessions yes, my bad. Should go to shared.

zorn-v · 2018-03-05T15:10:11Z

About writable_mode - I get errors with acl one. chown is my bet )

antonmedv · 2018-03-05T15:23:45Z

But you should set writable_mode in deploy.php

zorn-v · 2018-03-05T15:25:59Z

Yep, but I talk about default one.
Is acl so common ?

antonmedv · 2018-03-05T17:04:40Z

No, but chown may require sudo. acl no. And acl more flexible.

But I'm thinking to refactor it in v7.

Cryde · 2018-03-12T05:34:58Z

Will there be a 6.0.1 ? for the missing var/sessions ? :p

antonmedv · 2018-03-12T05:58:04Z

Yes :)
Sorry for delay.

Cryde · 2018-03-12T05:59:04Z

Don't be sorry ! You do an amazing work ! We can still add it ourself :D

zorn-v force-pushed the symfony-flex-compat branch from 6df4be4 to 6be861c Compare December 8, 2017 04:04

Symfony flex support

976de9a

zorn-v force-pushed the symfony-flex-compat branch from 6be861c to 976de9a Compare December 8, 2017 04:10

zorn-v mentioned this pull request Dec 8, 2017

Allow Symfony 4.0 in composer.json #1420

Closed

Cryde reviewed Jan 4, 2018

View reviewed changes

Init template

06b888a

zorn-v force-pushed the symfony-flex-compat branch from 2795f09 to 06b888a Compare January 5, 2018 07:02

antonmedv reviewed Jan 5, 2018

View reviewed changes

gander reviewed Jan 9, 2018

View reviewed changes

Removed unneccesary workaround

1fb62f1

antonmedv mentioned this pull request Feb 14, 2018

Symfony 4 Support #1547

Closed

antonmedv closed this Mar 5, 2018

Symfony flex support #1440

Symfony flex support #1440

Conversation

zorn-v commented Dec 8, 2017

Choose a reason for hiding this comment

zorn-v Jan 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gander Jan 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zorn-v Jan 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cryde commented Jan 4, 2018

zorn-v commented Jan 5, 2018 • edited Loading

antonmedv commented Jan 5, 2018

zorn-v commented Jan 5, 2018

antonmedv commented Jan 5, 2018

zorn-v commented Jan 5, 2018

antonmedv commented Jan 5, 2018

zorn-v commented Jan 5, 2018

Choose a reason for hiding this comment

zorn-v Jan 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zorn-v Jan 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antonmedv commented Jan 15, 2018

Cryde commented Jan 27, 2018

antonmedv commented Jan 27, 2018

zorn-v commented Mar 3, 2018 • edited Loading

zorn-v commented Mar 3, 2018 • edited Loading

antonmedv commented Mar 4, 2018

antonmedv commented Mar 5, 2018

zorn-v commented Mar 5, 2018 • edited Loading

antonmedv commented Mar 5, 2018

antonmedv commented Mar 5, 2018

zorn-v commented Mar 5, 2018

antonmedv commented Mar 5, 2018

zorn-v commented Mar 5, 2018 • edited Loading

antonmedv commented Mar 5, 2018

Cryde commented Mar 12, 2018

antonmedv commented Mar 12, 2018

Cryde commented Mar 12, 2018

zorn-v Jan 5, 2018 •

edited

Loading

gander Jan 12, 2018 •

edited

Loading

zorn-v Jan 5, 2018 •

edited

Loading

zorn-v commented Jan 5, 2018 •

edited

Loading

zorn-v Jan 5, 2018 •

edited

Loading

zorn-v Jan 6, 2018 •

edited

Loading

zorn-v commented Mar 3, 2018 •

edited

Loading

zorn-v commented Mar 3, 2018 •

edited

Loading

zorn-v commented Mar 5, 2018 •

edited

Loading

zorn-v commented Mar 5, 2018 •

edited

Loading