Skip to content

Lint sources on PHP 7.x via Github Action #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2025
Merged

Lint sources on PHP 7.x via Github Action #4016

merged 5 commits into from
Feb 10, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Feb 10, 2025 •
edited
Loading

adds a new Github Action workflow via lints against PHP 7.x to prevent problems like #3976 which got fixed in f1f7b61

the newly added check skips the following files, as these currently contain PHP8+ only syntax:

Script parallel-lint handling the __exec_command event returned with error code 1
Error: Parse error: syntax error, unexpected 'o755' (T_STRING), expecting ')' in src/Documentation/DocGen.php on line 311
Error: Parse error: syntax error, unexpected 'o755' (T_STRING) in src/Component/PharUpdate/Update.php on line 104
Error: Parse error: syntax error, unexpected ':', expecting ')' in tests/legacy/recipe/named_arguments.php on line 8

@antonmedv
Copy link
Member

Nice! Should we fix php8 file to be php7?

tests/legacy/recipe/named_arguments.php
src/Documentation/DocGen.php

Can be skipped.

But src/Component/PharUpdate/Update.php seems important.

@staabm
Copy link
Contributor Author

staabm commented Feb 10, 2025

sure - here you are

@antonmedv antonmedv merged commit 150818d into deployphp:7.x Feb 10, 2025
1 check passed
@staabm staabm deleted the lint branch February 10, 2025 15:10
clxmstaab pushed a commit to staabm/deployer that referenced this pull request Feb 10, 2025
@staabm
Lint sources on PHP 7.x via Github Action (deployphp#4016)
0c2cc3a 
* Lint sources on PHP 7.x via Github Action

* Skip PHP8 only files

* Fix PHP7 compat in rc/Component/PharUpdate/Update.php

* Simplify workflow

* Simplify even more
clxmstaab pushed a commit to staabm/deployer that referenced this pull request Feb 10, 2025
@staabm
Lint sources on PHP 8.2 via Github Action (deployphp#4016)
bb67bbb
@staabm staabm mentioned this pull request Feb 10, 2025
Merged
antonmedv added a commit that referenced this pull request Feb 10, 2025
@staabm @antonmedv
Lint sources on PHP 8.2 via Github Action (#4018)
bd1b91d 
* Lint sources on PHP 8.2 via Github Action (#4016)

* Update lint.yml

* Update lint.yml

---------

Co-authored-by: Anton Medvedev <anton@medv.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @antonmedv