Skip to content

Conversation

beejay777
Copy link
Contributor

No description provided.

@axispx
Copy link
Contributor

axispx commented May 27, 2017

Can you add the // add here comment at the end so that others can know where to add their data?

@axispx
Copy link
Contributor

axispx commented May 27, 2017

also, instead of giving empty links you can skip the data field

@axispx
Copy link
Contributor

axispx commented May 27, 2017

can you change //Add here to // add here to be consistent with the style format?

@beejay777
Copy link
Contributor Author

okay :)

@beejay777
Copy link
Contributor Author

Hope its all okay now :)

@beejay777 beejay777 closed this May 27, 2017
@axispx
Copy link
Contributor

axispx commented May 27, 2017

looks good to me

@axispx axispx reopened this May 27, 2017
@axispx axispx merged commit 4012366 into dev-circle-np:master May 27, 2017
axispx added a commit that referenced this pull request May 27, 2017
@axispx axispx mentioned this pull request May 27, 2017
axispx added a commit that referenced this pull request May 27, 2017
@axispx
Copy link
Contributor

axispx commented May 27, 2017

you have missed a comma before adding your data object which is causing an error and you have to provide indentation of 2 spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants