coderd/metricscache: fix test race (coder#4662)

ammario · web-flow · commit fa49ccd058c9 · 2022-10-20T02:36:00.000Z
diff --git a/coderd/metricscache/metricscache_test.go b/coderd/metricscache/metricscache_test.go
@@ -330,7 +330,7 @@ func TestCache_BuildTime(t *testing.T) {
 			if tt.want.loads {
 				require.Eventuallyf(t, func() bool {
 					stats := cache.TemplateBuildTimeStats(template.ID)
-					return assert.NotEmpty(t, stats)
+					return stats != codersdk.TemplateBuildTimeStats{}
 				}, testutil.WaitLong, testutil.IntervalMedium,
 					"BuildTime never populated",
 				)

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ func TestCache_BuildTime(t *testing.T) {`
`330`	`330`	`if tt.want.loads {`
`331`	`331`	`require.Eventuallyf(t, func() bool {`
`332`	`332`	`stats := cache.TemplateBuildTimeStats(template.ID)`
`333`		`- return assert.NotEmpty(t, stats)`
	`333`	`+ return stats != codersdk.TemplateBuildTimeStats{}`
`334`	`334`	`}, testutil.WaitLong, testutil.IntervalMedium,`
`335`	`335`	`"BuildTime never populated",`
`336`	`336`	`)`