This repository was archived by the owner on Sep 3, 2024. It is now read-only.
Bump up Mypy to 0.900 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps up versions of:
0.901).2.13.0).Clarifications:
Starting on mypy version
0.900, we would need to install Flask as an additional dependency to the pre-commit hook.The reason for this is that, until now, we did not really needed to install it, as mypy included some third-party stubs from the
python/typeshedrepository (reference), being Flaskv1.Xamong them. With the release of Flaskv2.X, those included stubs are deprecated, and will not be updated anymore (reference), making Flaskv2.Xstubs unavailable for out-of-the-box mypy.