Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enforcing chunkSize when TUS is not enabled and update the default TUS_CHUNK_SIZE to 8mb #24002

Merged
merged 13 commits into from
Nov 19, 2024
Merged

Fix enforcing chunkSize when TUS is not enabled and update the default TUS_CHUNK_SIZE to 8mb #24002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
235e547
do not enforce tus limits if it is not enabled
ComfortablyCoding Nov 7, 2024
af13270
add changeset
ComfortablyCoding Nov 7, 2024
ab09596
reword changeset
ComfortablyCoding Nov 7, 2024
ad814d2
fix typings
ComfortablyCoding Nov 7, 2024
8b325a1
Update packages/storage-driver-supabase/src/index.ts
ComfortablyCoding Nov 13, 2024
6aafc99
reduce default tus chunk size to 8mb
ComfortablyCoding Nov 14, 2024
53500f6
add warnings regarding driver restrictions
ComfortablyCoding Nov 14, 2024
073fe11
Merge branch 'main' into issue-24001
ComfortablyCoding Nov 14, 2024
bd3c9a0
rework multiple chunk size warning to a table
ComfortablyCoding Nov 15, 2024
b550210
reword cloudinary restriction
ComfortablyCoding Nov 15, 2024
45b9efd
move default chunk size to shared constants package
ComfortablyCoding Nov 15, 2024
692d951
update changeset with correct packages
ComfortablyCoding Nov 15, 2024
d7ef685
Update .changeset/cyan-sloths-appear.md
ComfortablyCoding Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typings
  • Loading branch information
@ComfortablyCoding
ComfortablyCoding committed Nov 7, 2024
commit ad814d2346494896753cb82a60b2adc89de8627d
2 changes: 1 addition & 1 deletion packages/storage-driver-azure/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export type DriverAzureConfig = {
endpoint?: string;
tus?: {
enabled: boolean;
chunkSize: number;
chunkSize?: number;
};
};

Expand Down
2 changes: 1 addition & 1 deletion packages/storage-driver-cloudinary/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export type DriverCloudinaryConfig = {
accessMode: 'public' | 'authenticated';
tus?: {
enabled: boolean;
chunkSize: number;
chunkSize?: number;
};
};

Expand Down
7 changes: 5 additions & 2 deletions packages/storage-driver-gcs/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export type DriverGCSConfig = {
apiEndpoint?: string;
tus?: {
enabled: boolean;
chunkSize: number;
chunkSize?: number;
};
};

Expand All @@ -37,7 +37,10 @@ export class DriverGCS implements TusDriver {
this.preferredChunkSize = tus?.chunkSize || DEFAULT_CHUNK_SIZE;

// chunkSize must be powers of 2 starting at 256kb
if (tus?.enabled && (tus.chunkSize < MINIMUM_CHUNK_SIZE || Math.log2(tus.chunkSize) % 1 !== 0)) {
if (
tus?.enabled &&
(this.preferredChunkSize < MINIMUM_CHUNK_SIZE || Math.log2(this.preferredChunkSize) % 1 !== 0)
) {
throw new Error('Invalid chunkSize provided');
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/storage-driver-supabase/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export type DriverSupabaseConfig = {
root?: string;
tus?: {
enabled: boolean;
chunkSize: number;
chunkSize?: number;
};
};

Expand Down
Loading