Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix item permissions not respected in drawer-item #24045

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ComfortablyCoding
Copy link
Contributor

@ComfortablyCoding ComfortablyCoding commented Nov 14, 2024

Scope

What's changed:

  • We now also consider the specific items update permissions within the drawer.

Potential Risks / Drawbacks

  • A drawer-item view is incorrectly disabled when it should not be, per my testing I have not found anywhere this is applicable.

Review Notes / Questions

  • Any alternative suggestions at a solution are welcome

Fixes #23910
Fixes #24050

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 455d7b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hanneskuettner
Copy link
Member

Do we also want to be very explicit and disable the save button if the user can't update either of the forms?

@ComfortablyCoding
Copy link
Contributor Author

ComfortablyCoding commented Nov 14, 2024

Do we also want to be very explicit and disable the save button if the user can't update either of the forms?

Yes, good point. Addressed in 455d7b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants