move voice heartbeat ack emiter #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27a595b to
f751490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by Discord User dseguy that noticed there is duplicated switch value.
At first i thought the first one is supposed to be
Op::VOICE_HEARTBEATand checked the history it was replaced f18fe92#diff-7a2f3798bc3eb078cbf2d218a055dafd03180366955c157e610bc585940e634aI double checked the doc to see what
Op::VOICE_HEARTBEATdoes https://discord.com/developers/docs/topics/voice-connections#heartbeating, it is something that the voice client needs to send, not something that will be received, so the code is already correct, and so I'm just moving the event emitter so it gets triggered.Tested.