Fix broken caching in interactions #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isset($interaction->attributes['member'])` would have worked as expected because it checks the array directly, but `isset($interaction->member)` does not work the same way, since it relies on a magic method (`__get`) that only gets invoked if the property is accessed, not when `isset()` is used. This means the function is effectively misimplemented, because `__get` cannot influence `isset()` checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how Discord interactions are handled, with a focus on improving type safety and clarity for application commands and autocomplete interactions. The main changes include updating type hints and conditional logic to distinguish between
ApplicationCommandandApplicationCommandAutocompleteinstances, and simplifying checks for interaction properties.Type safety and interaction handling improvements:
executeandcheckCommandmethods to accept bothApplicationCommandandApplicationCommandAutocompleteinstances, improving clarity and correctness in method signatures. [1] [2]handleto useinstanceofchecks forApplicationCommandandApplicationCommandAutocomplete, ensuring the correct handling and execution path for each interaction type.Code clarity and consistency:
isset()checks with direct property checks formember,user, andentitlementson theinteractionobject to fix a bug where these checks would always return false due to magic method getters being used. [1] [2]ApplicationCommand,ApplicationCommandAutocomplete, andApplicationCommandDatato support new type hints and improve code clarity.