Embed types #1396
Merged
Embed types #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to add the valid fields for each type as a const array to those classes |
valzargaming
commented
Sep 1, 2025
There was a problem hiding this comment.
Changing the return type of thumbnail is technically a breaking change, however it has the same data structure as image (for now). Unless someone's bot is explicitly checking for the type hinted result this change is inconsequential.
valzargaming
added a commit
that referenced
this pull request
Sep 4, 2025
These will be updated again with #1396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and extends the embed system in the DiscordPHP project to support multiple embed types and improve type safety for embed attributes. It introduces dedicated classes for each embed type, updates property definitions for better nullability and documentation, and adds support for new embed structures like
ProviderandThumbnail.Embed system refactoring and type support
EmbedRich,EmbedImage,EmbedVideo,EmbedGifv,EmbedArticle,EmbedLink,EmbedPollResult) and a type mapping inEmbed::TYPESto instantiate the correct class based on the embed's type. [1] [2] [3] [4] [5] [6] [7] [8] [9]Message.phpto use the new type mapping for instantiating embed objects.poll_resultembed type in the embed types list.Attribute and property improvements
Embed,Author,Footer,Field,Image,Video) to use?type|nullfor optional properties and updated docblocks for accuracy. [1] [2] [3] [4] [5] [6]thumbnailattribute inEmbedto use the newThumbnailclass instead ofImage, and added a getter for the newProviderattribute. [1] [2]New embed structure classes
ProviderandThumbnailto represent their respective embed structures, with appropriate fillable fields and documentation. [1] [2]