FEATURE: Add experimental plugin API to register messages nav dropdown #19294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also removes the `user-messages-nav` plugin outlet without deprecation in the redesigned user page navigation.
|
@lis2 Can you review this for me? Thank you! |
lis2
reviewed
Dec 5, 2022
| } | ||
|
|
||
| export function resetCustomUserNavMessagesDropdownRows() { | ||
| customUserNavMessagesDropdownRows.length = 0; |
There was a problem hiding this comment.
This is interesting way to reset. Is there a benefit of this approach over = []?
There was a problem hiding this comment.
Setting .length = 0 clears the original array whereas = [] is setting the variable to another array. If there is a spot in the code that has already referenced this constant, using = [] will actually not work properly.
lis2
reviewed
Dec 5, 2022
| return this.router.urlFor(parentRoute.name, this.model.username); | ||
| let value; | ||
|
|
||
| for (let i = this.messagesDropdownContent.length - 1; i >= 0; i--) { |
There was a problem hiding this comment.
I guess you used for loop to have access to value. Maybe it would better to use forEach but with old way function. Something like
this.messagesDropdownContent.forEach(function(content) {
})
There was a problem hiding this comment.
I'm actually looping in reverse here which is why I can't use forEach.
lis2
approved these changes
Dec 5, 2022
|
Thank you for reviewing @lis2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also removes the
user-messages-navplugin outlet withoutdeprecation in the redesigned user page navigation.