Skip to content

UX: thread list design changes #23348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 31, 2023
Merged

UX: thread list design changes #23348

merged 6 commits into from
Aug 31, 2023

Conversation

chapoi
Copy link
Contributor

@chapoi chapoi commented Aug 31, 2023 •
edited
Loading

New:

  • changes in font size/width
  • removed reply count
  • moved avatar position
image

@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Aug 31, 2023
pmusaraj
pmusaraj reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left one minor comment.

To do:
Make sure OP avatar doesn't appear in participants list to avoid being shown double

Is the todo for the current PR or for a follow-up?

plugins/chat/assets/javascripts/discourse/components/chat/thread-list/item.hbs
@@ -31,29 +28,31 @@

<div class="chat-thread-list-item__body">
<span class="chat-thread-list-item__last-reply-author">
{{@thread.preview.lastReplyUser.username}}:
@{{@thread.preview.lastReplyUser.username}}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick... and this isn't new to your PR, but the colon here will result in incorrect punctuation in some languages. For example, French requires a space on both sides of the colon (so the correct way to output this in French would be "@username : la di da").

To fix it, we should wrap the username here in an I18n label. There is one precedent in core:

https://github.com/discourse/discourse/blob/main/config/locales/client.en.yml#L1070

@pmusaraj
Copy link
Contributor

pmusaraj commented Aug 31, 2023 •
edited
Loading

Oh also @chapoi the test failures seem relevant:

     Failure/Error: measurement = Benchmark.measure { example.run }
       expected to find css ".chat-thread-list-item__om-user-avatar .chat-user-avatar .chat-user-avatar__container[data-user-card=\"bruce16\"] img" within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/SECTION[1]/DIV[1]/DIV[3]/DIV[2]/DIV[3]/DIV[1]/DIV[2]/DIV[1]/DIV[2]/DIV[1]"> but there were no matches

The test is looking for the .chat-thread-list-item__om-user-avatar, but PR removes that element.

@jjaffeux
Copy link
Contributor

Yep Im looking at this @pmusaraj thanks

@jjaffeux
Copy link
Contributor

Is the todo for the current PR or for a follow-up?

It's been addressed in this PR

@jjaffeux jjaffeux merged commit c9c2a73 into main Aug 31, 2023
@jjaffeux jjaffeux deleted the thread-index-design branch August 31, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmusaraj pmusaraj pmusaraj left review comments

@jjaffeux jjaffeux jjaffeux approved these changes

Assignees
No one assigned
Labels
chat PRs which include a change to Chat plugin
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapoi @pmusaraj @jjaffeux