FIX: use callbacks for relative bookmark timings #31498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/bookmark-timers-are-relative-to-topic-load-not-button-click/352146/2 |
pmusaraj
approved these changes
Feb 28, 2025
|
This pull request has been automatically marked as stale because it has been open for 60 days with no activity. To keep it open, remove the stale tag, push code, or add a comment. Otherwise, it will be closed in 14 days. |
|
Oh, @ZogStriP, I think we forgot to merge this one. |
6b12190 to
ad107cf
Compare
So the timings are relative to when the user clicks the button, not when the components are rendered in the browser. Ref - https://meta.discourse.org/t/-/352146
fcad799 to
f0bb6a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the timings are relative to when the user clicks the button, not when the components are rendered in the browser.
Ref - https://meta.discourse.org/t/-/352146