WIP: Fix inline spoilers when using toolbar Blur Spoiler #31791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
commented
Mar 13, 2025
| } else { | ||
| // NOTE: We need to add IGNORE here otherwise the convertFromMarkdown | ||
| // markdown parser will parse the text as a block instead of inline. | ||
| text = |
There was a problem hiding this comment.
This is really not ideal and probably breaks other stuff...I just have no idea how to get prosemirror-markdown to parse as inline bbcode for e.g. [spoiler]test[/spoiler], it only figures out it's inline with something before or after the spoiler tags
When we do `applySurround`, if we have an active ProseMirror selection via this.view.state.selection, then we should not use the "example text" when attempting to add [spoiler] bbcode. In addition to this, when we call `convertFromMarkdown` we must add an additional bit of text at the beginning otherwise the parser will always parse e.g. `[spoiler]test[/spoiler]` as a spoiler block bbcode rather than inline bbcode
b9e5977 to
6841e5e
Compare
|
This pull request has been automatically marked as stale because it has been open for 60 days with no activity. To keep it open, remove the stale tag, push code, or add a comment. Otherwise, it will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do
applySurround, if we have an active ProseMirrorselection via this.view.state.selection, then we should not use
the "example text" when attempting to add [spoiler] bbcode.
In addition to this, when we call
convertFromMarkdownwe mustadd an additional bit of text at the beginning otherwise the
parser will always parse e.g.
[spoiler]test[/spoiler]asa spoiler block bbcode rather than inline bbcode