DEV: Fix flaky system test #31822
Merged
DEV: Fix flaky system test #31822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Homepage allows users to pick their homepage" system test was flaky because it was assuming that waiting 5 seconds was enough for the request to save the user's preferences to complete. This may be true in development where we have powerful development machines. In production, Capybara's default wait time is actually 10 seconds so we should respect that.
nbianca
approved these changes
Mar 14, 2025
tgxworld
added a commit
that referenced
this pull request
May 28, 2025
The "Homepage allows users to pick their homepage" system test was flaky because it was assuming that waiting 5 seconds was enough for the request to save the user's preferences to complete. This may be true in development where we have powerful development machines. In production, Capybara's default wait time is actually 10 seconds so we should respect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Homepage allows users to pick their homepage" system test was flaky
because it was assuming that waiting 5 seconds was enough for the
request to save the user's preferences to complete. This may be true in
development where we have powerful development machines. In production,
Capybara's default wait time is actually 10 seconds so we should respect
that.