DEV: Customization enhancements for the Glimmer Post Stream #32063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the outletArgs in the `post-content-cooked-html` outlet - Added a .isSmallAction into the Post model
84a8d60 to
94bf44c
Compare
davidtaylorhq
approved these changes
Apr 28, 2025
Co-authored-by: David Taylor <david@taylorhq.com>
This was referenced May 4, 2025
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
This commit introduces various enhancements and refactoring to the Glimmer Post Stream codebase, focusing on the integration and usage of `PluginOutlet` components, improved handling of post attributes, and the introduction of new properties and methods. Key changes include: 1. **`PluginOutlet` Integration**: - Added `PluginOutlet` components across multiple files, such as `post.gjs`, `post/avatar.gjs`, and `post-stream.js`, to allow plugins to extend the functionality of posts, avatars, and metadata more effectively. - Introduced `postOutletArgs` to pass structured arguments, enabling better customization and extensibility for plugins. - Added PluginOutlet usage in `post/avatar.gjs` for avatar-related customizations. 2. **Refactored Post Attributes**: - Enhanced handling of post attributes by deprecating the `includePostAttributes` method in favor of `addTrackedPostProperties` for improved compatibility with the Glimmer Post Stream. - Added a new `isSmallAction` computed property to the `Post` model to identify small actions or split topics. 3. **Improved Query Parameters**: - Introduced `topicPageQueryParams` to manage query parameters for topics more effectively, facilitating smoother updates and interactions in components that won't need to inject the topic controller or the router service to get these parameter values. --------- Co-authored-by: David Taylor <david@taylorhq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces various enhancements and refactoring to the Glimmer Post Stream codebase, focusing on the integration and usage of
PluginOutletcomponents, improved handling of post attributes, and the introduction of new properties and methods. Key changes include:PluginOutletIntegration:PluginOutletcomponents across multiple files, such aspost.gjs,post/avatar.gjs, andpost-stream.js, to allow plugins to extend the functionality of posts, avatars, and metadata more effectively.postOutletArgsto pass structured arguments, enabling better customization and extensibility for plugins.post/avatar.gjsfor avatar-related customizations.Refactored Post Attributes:
includePostAttributesmethod in favor ofaddTrackedPostPropertiesfor improved compatibility with the Glimmer Post Stream.isSmallActioncomputed property to thePostmodel to identify small actions or split topics.Improved Query Parameters:
topicPageQueryParamsto manage query parameters for topics more effectively, facilitating smoother updates and interactions in components that won't need to inject the topic controller or the router service to get these parameter values.