-
Notifications
You must be signed in to change notification settings - Fork 8.6k
WIP: Themeable site settings #32233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
martin-brennan
wants to merge
23
commits into
main
Choose a base branch
from
feature/theme-site-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Themeable site settings #32233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c560c7
to
972166b
Compare
972166b
to
7c1871c
Compare
* adding page at /admin/config/theme-site-settings, need to show the actual (ruby?) values instead of the db values, not sure if we want to use the actual controls here…should we allow changing this in one place? * maybe the theme-site-settings page should invert, show a list of all the themes and then the dropdown is the settings, then you can see what all the themes are overriding the values to at once? then pencil icon to edit the theme
Need to finalise controller and helper still, probably make it easier to get "site-setting-like" conversion of values from and to the DB, the rb_value and db_value stuff
Also send preloaded theme site setting overrides to client
Also make sure not to use SiteSetting.get here as it throws an error -- call `current` and `defaults` directly
also adding updating setting cache and logging changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT, NO REVIEW YET PLEASE