Skip to content

WIP: Themeable site settings #32233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Conversation

martin-brennan
Copy link
Contributor

DRAFT, NO REVIEW YET PLEASE

@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label Apr 9, 2025
@martin-brennan martin-brennan force-pushed the feature/theme-site-settings branch from 1c560c7 to 972166b Compare April 9, 2025 06:00
@martin-brennan martin-brennan force-pushed the feature/theme-site-settings branch from 972166b to 7c1871c Compare April 9, 2025 06:00
* adding page at /admin/config/theme-site-settings, need to show the actual (ruby?) values instead of the db values, not sure if we want to use the actual controls here…should we allow changing this in one place?
* maybe the theme-site-settings page should invert, show a list of all the themes and then the dropdown is the settings, then you can see what all the themes are overriding the values to at once? then pencil icon to edit the theme
Need to finalise controller and helper still, probably make it
easier to get "site-setting-like" conversion of values from and
to the DB, the rb_value and db_value stuff
Also send preloaded theme site setting overrides to client
Also make sure not to use SiteSetting.get here as it
throws an error -- call `current` and `defaults` directly
also adding updating setting cache and logging changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n PRs which update English locale files or i18n related code
Development

Successfully merging this pull request may close these issues.

1 participant