UX: Refactor the edit topic title UI #32339
Conversation
app/assets/javascripts/discourse/app/components/user-status-picker.gjs
Outdated
Show resolved
Hide resolved
|
Just wondering – how will this affect tablet users? The PR says mobile stays the same, but tablets don’t have hover either. So will there still be a button for tablets using the desktop view? If not, that might cause two issues: it's harder to discover that editing is possible, and easier to accidentally tap something you didn’t know was there – especially on the right side, where there's no visible text. 1000017897.mp4 |
Thanks for bringing this up. We have added a check for tablet users as well. |
…nto edit-topic
When using headless chrome to run qunit tests, it matches the `hover: none` media query, so this commit adds `isTesting()` to the condition. Also removes the `mobileView` dependency, since we're aiming to make that purely viewport-width dependent in future. Touch-based UX changes should be entirely handled by media queries.
Using scroll position (e.g. `currentPostId`) is very tricky to make consistent, so this commit splits `jumpTop` out of `titleClick`. That way, clicking the title can always have consistent behavior, while allowing the topic timeline to keep its jumpTop behavior.
This reverts commit adcb663.
This PR changes the UI for editing a topic on desktop. For mobile it will remain the same.
topic-title-edit.mp4