DEV: Refactor tests & add animation #32547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/system/header_search_spec.rb
Outdated
|
|
||
| RSpec.describe "Header Search - Responsive Behavior", type: :system do | ||
| fab!(:user) | ||
| fab!(:topics) { Fabricate.times(20, :post).map(&:topic) } |
There was a problem hiding this comment.
No need to do this, it's slow and we have a "cheat" way of doing this type of thing where you need to scroll a lot vertically:
discourse/spec/support/system_helpers.rb
Lines 178 to 187 in abee294
spec/system/header_search_spec.rb
Outdated
| visit "/" | ||
|
|
||
| # Default desktop view should show search field | ||
| expect(page).to have_no_css(".floating-search-input") |
There was a problem hiding this comment.
We have a page object for search related system spec stuff already https://github.com/discourse/discourse/blob/abee294616a064e4de40d8e8eb052ea571e2203c/spec/system/page_objects/pages/search.rb , you should use this where possible in this spec
martin-brennan
approved these changes
May 9, 2025
@martin-brennan would you mind going through again? I added in all of your reccomendations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
New
new-scroll-headersearch.mp4
Old
old-scroll-headersearch.mp4