Add category moderation groups and more attributes to generic importer #32561
Conversation
script/bulk_import/generic_bulk.rb
Outdated
| @@ -562,6 +631,7 @@ def import_user_options | |||
| email_level: row["email_level"], | |||
| email_messages_level: row["email_messages_level"], | |||
| email_digests: row["email_digests"], | |||
| hide_profile_and_presence: row["hide_profile_and_presence"] || false, | |||
There was a problem hiding this comment.
There seems to be some work to make this setting more granular by splitting it into hide_profile and hide_presence, but hide_profile_and_presence still appears to be kept in sync as follows:
discourse/app/models/user_option.rb
Lines 228 to 235 in 4117b08
Simply setting hide_profile_and_presence might be problematic. You could:
- Set both
hide_profileandhide_presenceto the value ofhide_profile_and_presence, if it’s explicitly provided inprocess_user_options - Update the converter framework to support to also support
hide_profileandhide_presenceand replicate the logic above to keep them in sync
There was a problem hiding this comment.
I've made a couple of updates here. Let me know if this would work? This is actually not used in the converter. It was due to an error that was caused during the import that requested this to be added if I remember correctly.
There was a problem hiding this comment.
This was the error:
ERROR: null value in column "hide_profile_and_presence" of relation "user_options" violates not-null constraint
…user option, and multi-tag-group support
979c141 to
016ca7a
Compare
| @@ -1225,6 +1243,7 @@ def process_group(group) | |||
|
|
|||
| group[:created_at] ||= NOW | |||
| group[:updated_at] ||= group[:created_at] | |||
| group[:assignable_level] ||= Group::ALIAS_LEVELS[:nobody] if @assign_plugin_enabled | |||
There was a problem hiding this comment.
I think it's safe to set this unconditionally. There's no need for @assign_plugin_enabled in that case. A comment might be enough.
| visibility_level: row["visibility_level"], | ||
| members_visibility_level: row["members_visibility_level"], | ||
| mentionable_level: row["mentionable_level"], | ||
| messageable_level: row["messageable_level"], | ||
| } | ||
| group_data[:assignable_level] = row["assignable_level"] if defined?(::DiscourseAssign) |
There was a problem hiding this comment.
You can remove the condition here.
This PR improves the generic bulk import and base scripts by adding support for several previously unimplemented features and attributes: