We should remove the rounded corners here:

When Im in this state:

Pressing tab should bring me to the first item, atm I need multiple tabs.

The last button has no hover state on desktop.

Can we avoid destroying/re-creating when my click ends up not changing the caret position?

@chapoi It's not due to this work, but it's very annoying that showing a modal is removing the browsers scrollbars, it makes the page all jumpy, I know there are techniques to avoid this, could designers try to give it a go please?

When I had focus through tab on one of the items menu and I press escape, I don't get back my caret position in the composer.

Im not sure we should have cursor: pointer on the link given we now treat is as text. It's debatable, given this is still an action. But my reasoning is that seeing the cursor makes me think it's going to open the link right away. What do you think @chapoi ?

When I edit a link by opening the modal, when I close it I don't get back my caret position in the composer.

We have no spacing between the back button on edit mode:

While in normal mode we have a lot of spacing:

Doesnt feel right @chapoi

What is this button, didnt get it in my tests?

Im not sure we should have cursor: pointer on the link given we now treat is as text. It's debatable, given this is still an action. But my reasoning is that seeing the cursor makes me think it's going to open the link right away. What do you think @chapoi ?

Tricky one… I'd say keep the pointer, indicating something can be done feels most important. We could consider using context-menu maybe?

While in normal mode we have a lot of spacing:

Yes, I know, but that left side spacing is very hard/impossible to get right due to the use of grid. I'll see if I can tweak it a bit.

What is this button, didnt get it in my tests?

Shouldn't that be "unlink"?

Im not sure we should have cursor: pointer on the link given we now treat is as text. It's debatable, given this is still an action. But my reasoning is that seeing the cursor makes me think it's going to open the link right away. What do you think @chapoi ?

Tricky one… I'd say keep the pointer, indicating something can be done feels most important. We could consider using context-menu maybe?

FWIW slack is doing the regular text cursor, and some styling on hover of the link.

What is this button, didnt get it in my tests?

Shouldn't that be "unlink"?

Yes it should, but never got it showing

Yes it should, but never got it showing

@jjaffeux I’ll respond to the other things today, but getting this out first: Unlink is only available for non-autolinks, aren’t they working with [regular](links)?

I get it may be confusing, but I think supporting removing this autolink will still be confusing, with the caveat of being more work. Making a URL not autolink requires escaping it in the markdown, and I didn't think of a good way to make the escaped text linkable again/autolink on the rich editor - I think it's just simpler to omit the option in this case.

Yes it should, but never got it showing

@jjaffeux I’ll respond to the other things today, but getting this out first: Unlink is only available for non-autolinks, aren’t they working with [regular](links)?

I get it may be confusing, but I think supporting removing this autolink will still be confusing, with the caveat of being more work. Making a URL not autolink requires escaping it in the markdown, and I didn't think of a good way to make the escaped text linkable again/autolink on the rich editor - I think it's just simpler to omit the option in this case.

OK I see, we can for sure start like this and see the feedback we get 👍

Can we avoid destroying/re-creating when my click ends up not changing the caret position?

@jjaffeux I don't think we have an easy alternative in this case, what's destroying the menu is the closeOnClickOutside.

EDIT: We can skip the menu's default closeOnClickOutside, use our own, and check the caret position before deciding to close it. Doesn't seem that much work, I can test it out.