UX: don't always fill username for forgot password #32646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
approved these changes
May 8, 2025
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/autofill-with-username-in-forgot-password-modal/365310/2 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-1pm-utc/291852/470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here: https://meta.discourse.org/t/autofill-with-username-in-forgot-password-modal/365310
When
hide_email_address_takenis enabled, we don't want to populate the username in the forgot email input, because we require an email address. This will remove username content that doesn't look like an email when that site setting is enabled.Before (username populated when email required):
After (username not populated, email is):
