Skip to content

DEV: Port the about page extra groups functionality into core #32659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

Drenmi
Copy link
Contributor

@Drenmi Drenmi commented May 9, 2025

What is this change?

We want to merge the theme component that allows admins to display extra groups on the about page:

Screenshot 2025-05-13 at 10 57 31 AM

The settings for this are now under About your site:

Screenshot 2025-05-13 at 10 38 11 AM

All the code is lift-and-shift, with some minor adjustments, e.g. theme components can't use the group_list setting type, but it has been converted to that here.

Also the system tests for the admin controls are new.

Note: This is gated behind a hidden site setting to avoid double rendering while we deprecate the theme component.

@Drenmi Drenmi force-pushed the dev/merge-additional-about-groups branch 3 times, most recently from 3e491d9 to 947e085 Compare May 9, 2025 03:32
@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label May 9, 2025
@Drenmi Drenmi force-pushed the dev/merge-additional-about-groups branch 11 times, most recently from a21f621 to b986560 Compare May 13, 2025 02:31
@Drenmi Drenmi marked this pull request as ready for review May 13, 2025 02:40
@Drenmi Drenmi force-pushed the dev/merge-additional-about-groups branch 3 times, most recently from 035524e to b31b974 Compare May 13, 2025 02:56
@Drenmi Drenmi force-pushed the dev/merge-additional-about-groups branch from b31b974 to 6057c05 Compare May 13, 2025 05:28
@Drenmi Drenmi force-pushed the dev/merge-additional-about-groups branch from 6057c05 to c791792 Compare May 13, 2025 06:11
@Drenmi Drenmi merged commit a445e8c into main May 14, 2025
16 checks passed
@Drenmi Drenmi deleted the dev/merge-additional-about-groups branch May 14, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n PRs which update English locale files or i18n related code
Development

Successfully merging this pull request may close these issues.

2 participants