Skip to content

DEV: refactor select-kit utils mixin to selectKitPropUtils class decorator #32665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025

Conversation

tyb-talks
Copy link
Contributor

@tyb-talks tyb-talks commented May 9, 2025

Follow up to refactoring the generic utils mixin used in select-kit components in #32594.

This PR follows a different approach as the util functions related to properties here aren't easily extracted without a major change to the interface due to the dependency on this.selectKit. These util functions are instead declared on the prototype with a class decorator which ensures the same behaviour is maintained without relying on a mixin.

It's largely a lift-and-shift with some minor refactoring of the conditional logic to reduce nesting and improve readability of the functions.

@tyb-talks tyb-talks force-pushed the dev-select-kit-property-utils branch from 77b983a to ffc46b2 Compare May 22, 2025 08:25
@tyb-talks tyb-talks marked this pull request as ready for review May 22, 2025 09:58
@tyb-talks tyb-talks force-pushed the dev-select-kit-property-utils branch from 12bdaa1 to 342b19e Compare May 22, 2025 11:46
@tyb-talks tyb-talks merged commit 6cda3c7 into main May 23, 2025
15 checks passed
@tyb-talks tyb-talks deleted the dev-select-kit-property-utils branch May 23, 2025 01:03
@tyb-talks tyb-talks changed the title DEV: refactor select-kit utils mixin to property-utils lib DEV: refactor select-kit utils mixin to selectKitPropUtils class decorator May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants