FIX: resolve discard draft keep editing #32667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaffeux
reviewed
May 26, 2025
jjaffeux
reviewed
May 26, 2025
app/assets/javascripts/discourse/tests/acceptance/composer-test.js
Outdated
Show resolved
Hide resolved
jjaffeux
approved these changes
May 26, 2025
|
Great dig, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where clicking keep editing in the discard modal dialog would result in the composer auto save being disabled. Because of this updates to drafts after this point can easily be lost.
The issue was that the
cancelComposerwas not resolving the promise, and therefore not settingskipAutoSaveto false in the final step.This change also includes another fix for an issue that was revealed where the discard draft dialog would continually open again after we close it. This would happen when editing a draft while viewing a different topic. It wasn't noticed before as the
keep editingbutton would result in the code hanging at theawait this.cancelComposer(opts)stage and not opening the composer again for the new topic reply.