FIX: issuses with fast consecutive clicks on delete/restore buttons #32743
+43
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SamSaffron
reviewed
May 20, 2025
| @@ -568,10 +570,13 @@ export default class Post extends RestModel { | |||
| } | |||
|
|
|||
| destroy(deletedBy, opts) { | |||
| this.set("isDeleting", true); | |||
| return this.setDeletedState(deletedBy).then(() => { | |||
There was a problem hiding this comment.
I think the finally might not be in the right spot? it only operates on the internal promise, we probably want outside.
To simplify I would probably just make this an async function.
There was a problem hiding this comment.
Thanks for your suggestion! I've updated the code to address both issues:
- Converted both
destroyandrecovermethods to proper async functions - Moved the
finallyblock outside to wrap the entire operation, not just the internal promise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: issues with fast consecutive clicks on delete/restore buttons
issuses: when users rapidly click the delete/recover buttons on posts, asynchronous backend requests can get out of sync with the UI button state, leading to inconsistent behavior and error messages.
look this issue video：
2025-05-15.180327.mp4
what i do: adds state tracking functionality to prevent race conditions when users rapidly click delete/recover buttons:
Added an isDeleting property to track ongoing delete operations
Added an isRecovering property to track ongoing recover operations
Used these properties to disable buttons during API operations