FIX: Bug with 2FA setup right after signup #32754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
reviewed
May 16, 2025
| @@ -2263,6 +2263,10 @@ def secure_session_confirmed? | |||
| secure_session["confirmed-session-#{current_user.id}"] == "true" | |||
| end | |||
|
|
|||
| def session_is_trusted? | |||
| secure_session_confirmed? || user_just_created | |||
There was a problem hiding this comment.
Just out of curiosity, what is special about the secure session that a user which has just has been created doesn't have it?
There was a problem hiding this comment.
The confirmed secure session is done with a check on the password or the passkey while user is already logged in. It's an extra security step. Not practically useful for a new user, almost zero chance that a new account is immediately compromised, so we remove the extra friction here for users. (Particularly annoying for sites with 2FA enforced).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.