Skip to content

FIX: correctly guard for missing close method #32760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

FIX: correctly guard for missing close method #32760

merged 1 commit into from
May 16, 2025

Conversation

SamSaffron
Copy link
Member

@SamSaffron SamSaffron commented May 15, 2025 •
edited
Loading

?.close() is an unsafe pattern

test = {}
test?.close()
VM363:1 Uncaught TypeError: test?.close is not a function
    at <anonymous>:1:7

@SamSaffron
FIX: incorrect guard when checking for close
3550f96 
`?.close()` is an unsafe pattern

```
test = {}
test?.close()
VM363:1 Uncaught TypeError: test?.close is not a function
    at <anonymous>:1:7
```
@SamSaffron SamSaffron changed the title uppy api fix FIX: correctly guard for missing close method May 15, 2025
@SamSaffron
Copy link
Member Author

fail is flaky ci

@SamSaffron SamSaffron mentioned this pull request May 16, 2025
Merged
@SamSaffron SamSaffron merged commit 8437288 into main May 16, 2025
17 of 19 checks passed
@SamSaffron SamSaffron deleted the uppy-api-fix branch May 16, 2025 03:04
@SamSaffron SamSaffron restored the uppy-api-fix branch May 16, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgxworld tgxworld tgxworld approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamSaffron @tgxworld