DEV: Refactor Chat::LookupChannelThreads to follow best practices #32771
+353
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `model` where possible - extract threads fetching logic to its own action - refactor specs to follow current guidelines/best practices
6c4b047 to
c30b8d8
Compare
Flink
commented
May 19, 2025
| ) | ||
| .limit(params.limit) | ||
| .offset(params.offset) | ||
| Chat::Action::FetchThreads.call( |
There was a problem hiding this comment.
Extracted all the logic/SQL to its own class, as it improves global readability of the service and makes it easier to spec all the edge-cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modelwhere possible