FIX: check if sidebar hidden and remove scrollLock when hiding hamburger menu #32775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
approved these changes
May 16, 2025
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/dashboard-freezes-until-sidebar-is-opened/366402/2 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-9pm-utc/291850/506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here: https://meta.discourse.org/t/dashboard-freezes-until-sidebar-is-opened/366402
This is a follow-up to #32651, when navigating from the homepage to admin the hamburger gets force-hidden because we switch from the dropdown to the sidebar nav but the scrollLock was unintentionally left behind.
This makes sure we're only messing with hamburger state when the sidebar is hidden (with
{{hideApplicationSidebar}}) and also removes the scroll lock when the hamburger is force-hidden.