Skip to content

FIX: attempts to fix flaky in stat spec #32784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

FIX: attempts to fix flaky in stat spec #32784

merged 1 commit into from
May 18, 2025

Conversation

jjaffeux
Copy link
Contributor

I suspect that by having an integer and not a float sometimes the value we get is converted to 0.

This is the error we have atm:

Failure/Error: measurement = Benchmark.measure { example.run }

  expected: 0.75
       got: 0.0

  (compared using ==)

This might not fix it, but it feels right to make this change.

I suspect that by having an integer and not a float sometimes the value we get is converted to 0.

This is the error we have atm:

```
Failure/Error: measurement = Benchmark.measure { example.run }

  expected: 0.75
       got: 0.0

  (compared using ==)
```

This might not fix it, but it feels right to make this change.
@jjaffeux jjaffeux merged commit 82ac698 into main May 18, 2025
17 checks passed
@jjaffeux jjaffeux deleted the specs-1 branch May 18, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants