DEV: Improve template-override deprecations (stable) #32801
+38
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d6448b to
6d65e4a
Compare
These changes are backported from `main`, so that stable users receive better feedback about this upcoming deprecation. - Update Meta topic URLs - Add theme/plugin identification to deprecation - Enable admin warning banner https://meta.discourse.org/t/355668
6d65e4a to
9fbd471
Compare
CvX
approved these changes
May 19, 2025
| @@ -31,11 +50,15 @@ export default { | |||
| } | |||
|
|
|||
| let componentName = templateKey; | |||
| const finalOverrideModuleName = moduleNames[moduleNames.length - 1]; | |||
There was a problem hiding this comment.
🏌️
Suggested change
| const finalOverrideModuleName = moduleNames[moduleNames.length - 1]; | |
| const finalOverrideModuleName = moduleNames.at(-1); |
There was a problem hiding this comment.
Good call! But will skip for now though, since I want to keep this backport as close to the main version as possible so that there are fewer conflicts on the next stable bump.
(and it's not worth changing in main, since we'll be dropping this initializer in a couple of weeks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are backported from
main, so that stable users receive better feedback about this upcoming deprecation.Update Meta topic URLs
Add theme/plugin identification to deprecation
Enable admin warning banner
https://meta.discourse.org/t/355668