PERF: fixes N+1 for automation plugin #32810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjaffeux
commented
May 20, 2025
•
- Add a safeguard until we implement pagination for the index, it ensures we won't try to load more than 500 automations ever.
- Includes the fields of the automation so we don't have an N+1 and also filter them in ruby land instead of doing two additional queries
- Ensures a field object in the field serializer is capable to find the loaded automation associated to it instead of trying to reload it
- Includes pending_automations to avoid an N+1
- Add a safeguard until we implement pagination for the index, it ensures we won't try to load more than 500 automations ever. - Includes the fields of the automation so we don't an N+1 and also filter them in ruby land instead of doing two additional queries - Ensures a field object in the field serializer is capable to find the loaded automation associated to it instead of trying to reload it - Includes pending_automations
lis2
approved these changes
May 20, 2025
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.