Skip to content

DEV: remove old themes/components code #32875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

DEV: remove old themes/components code #32875

merged 2 commits into from
May 26, 2025

Conversation

lis2
Copy link
Contributor

@lis2 lis2 commented May 23, 2025

Recently, themes page was rebranded and put /admin/config/customize/themes. In this PR, old /admin/customize/themes was removed. In addition, when an admin visits an old URL, they are redirected to the new one.

@lis2 lis2 force-pushed the remove-old-themes-code branch from 0892aac to e43ffed Compare May 23, 2025 02:14
Recently, themes page was rebranded and put `/admin/config/customize/themes`. In this PR, old `/admin/customize/themes` was removed.  In addition, when an admin visits an old URL, they are redirected to the new one.
@lis2 lis2 force-pushed the remove-old-themes-code branch from e43ffed to f305b83 Compare May 23, 2025 02:45
Copy link
Contributor

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of code in this file that we no longer need:

app/assets/javascripts/admin/addon/routes/admin-customize-themes.js

@lis2 lis2 merged commit c4ff6bd into main May 26, 2025
16 checks passed
@lis2 lis2 deleted the remove-old-themes-code branch May 26, 2025 01:21
@lis2 lis2 restored the remove-old-themes-code branch May 26, 2025 01:21
@lis2 lis2 deleted the remove-old-themes-code branch May 26, 2025 01:21
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/back-button-in-theme-component-edit-code-loads-old-themes-and-components/366830/10

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/daily-summary-5am-utc/291851/495

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/daily-summary-1pm-utc/291852/490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants