Skip to content

FIX: Avoid double redirect after installing a theme #32876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

FIX: Avoid double redirect after installing a theme #32876

merged 1 commit into from
May 23, 2025
+9 −4

Conversation

Drenmi
Copy link
Contributor

@Drenmi Drenmi commented May 23, 2025

What is this change?

Clearing of params is now happening in the addTheme callback in the call site. Calling it in the component in willDestroy results in a double redirect which breaks the redirection to the components tab.

@tgxworld
Copy link
Contributor

@Drenmi Just noting that the test failures are legit.

@Drenmi Drenmi force-pushed the fix/install-theme-double-redirect branch from 35ffa14 to a568236 Compare May 23, 2025 08:25
@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label May 23, 2025
@Drenmi Drenmi force-pushed the fix/install-theme-double-redirect branch from a568236 to 4b5c923 Compare May 23, 2025 08:41
@Drenmi Drenmi merged commit c880aa7 into main May 23, 2025
16 checks passed
@Drenmi Drenmi deleted the fix/install-theme-double-redirect branch May 23, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lis2 lis2 lis2 approved these changes

Assignees
No one assigned
Labels
i18n PRs which update English locale files or i18n related code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drenmi @tgxworld @lis2