UX: fix search results unreachable bottom results and more button #32883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrusselburg
approved these changes
May 23, 2025
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/search-in-header-gives-too-deep-results/362973/7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta report: https://meta.discourse.org/t/search-in-header-gives-too-deep-results/362973
The general problem of our
menu-panelis that it had no proper max-height set, which mean you have to scroll the page instead of the panel to see bottom results. In the new header-search setup however, scrolling the page makes the panel disappear, effectively locking you out.This commit adds a best-estimate max-height on the parent level
menu-panel, dependent on where the search is triggered from (header VS welcome banner)