FIX: restore category text color field #32915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grubba27
reviewed
May 30, 2025
app/assets/javascripts/discourse/app/components/edit-category-general.gjs
Outdated
Show resolved
Hide resolved
jjaffeux
reviewed
May 30, 2025
app/assets/javascripts/discourse/app/components/edit-category-general.gjs
Show resolved
Hide resolved
|
LGTM, tested locally 🚀 I pushed a small commit to simplify tests, and yes I recommend a library for this color diff thing, but up to you 👍 |
jjaffeux
approved these changes
May 30, 2025
megothss
pushed a commit
that referenced
this pull request
Jun 3, 2025
Restores the category text/foreground color field that was removed in #32015. We are also retaining the auto text color selection that was introduced and applying on background color change rather than when the form is saved. The text color algorithm has been changed from color brightness to use color difference instead, which appears to be more reliable. Algorithm for color difference: https://www.w3.org/TR/AERT/#color-contrast --------- Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the category text/foreground color field that was removed in #32015.
We are also retaining the auto text color selection that was introduced and applying on background color change rather than when the form is saved. The text color algorithm has been changed from color brightness to use color difference instead, which appears to be more reliable.
Algorithm for color difference: https://www.w3.org/TR/AERT/#color-contrast
Screen.Recording.2025-05-26.at.1.46.00.PM.mov
Internal ref: /t/154650