DEV: First pass at groups step for Discourse converter
#32919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3lase
commented
May 26, 2025
Comment on lines
+27
to
+32
| if item[:original_flair_upload_id].present? | ||
| IntermediateDB::Upload.create_for_file( | ||
| path: item[:flair_path], | ||
| filename: item[:flair_filename], | ||
| ) | ||
| end |
There was a problem hiding this comment.
🗒️ Confirm if path can be used as-is for non-local upload dumps
There was a problem hiding this comment.
There's no easy answer for that. It depends on how we are going to execute the converter and where uploads are stored. Always local? Or maybe on S3? How are we going to download them from S3? The files might not always be available for download without S3 credentials.
Starting with a full backup that's restored locally seems to be the easiest starting point for running a converter.
There was a problem hiding this comment.
Yes, the current implementation should work with local files
s3lase
commented
May 26, 2025
gschlager
reviewed
May 26, 2025
30518c1 to
681c53f
Compare
s3lase
added a commit
that referenced
this pull request
May 27, 2025
This change implements converter step for converting Discourse `permalinks` to intermediate DB format needed for import into Discourse.
group step for Discourse convertergroups step for Discourse converter
This change implements converter step for converting Discourse `groups` to intermediate DB format needed for import into Discourse. It tracks seeded automatic groups which will then mapped to seeded automatic groups in the destination Discourse instance instead of being imported as new groups
343ee51 to
1dcb5a5
Compare
6a4ffb5 to
f07383b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements converter step for converting Discourse
groupsto intermediate DB format needed for import into Discourse.It tracks seeded automatic groups which will then mapped to seeded automatic groups in the destination Discourse instance instead of being imported as new groups