DEV: Update allowed supported locales in translation editor #32920
+71
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanrizzi
approved these changes
May 26, 2025
pmusaraj
approved these changes
May 26, 2025
app/assets/javascripts/discourse/app/components/post-translation-editor.gjs
Show resolved
Hide resolved
This was referenced May 28, 2025
Merged
nattsw
added a commit
to discourse/discourse-translator
that referenced
this pull request
May 29, 2025
The anon language switcher feature is moving to core, so we are removing it from this plugin. Similarly, in discourse/discourse#32920, we introduced `experimental_content_localization_supported_locales`, but there was a borked migration that copies `automatic_translation_target_languages` (from this plugin) to `experimental_content_localization_supported_locales` (core) - the migration was a no-op. Language switcher relies on old setting, so it was good it was borked. This PR also adds a migration to do a rename as the old setting will not be used any more. /t/154911
nattsw
added a commit
that referenced
this pull request
May 29, 2025
Related: - discourse/discourse-translator#308 - #32920 (setting introduced) Moving the switcher to core, as the setting is now in core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
This update adds a new site setting:
where admins can set the supported languages for content localizations, which will populate the picker inside the translation composer editor. The update also ensures the content localization settings are shown in the site setting area: "localization"
📷 Screenshots