DEV: update composer similar topics limit #32934
Merged
+4
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
approved these changes
May 27, 2025
There was a problem hiding this comment.
Btw, the topic doesn't indicate why 10 or 3. Did you quote the wrong topic?
Since the descriptive "max similar results" is now gone, can we add a CONST indicating something like SIMILAR_TOPICS_LIMIT? Super nitpicky but it def feels like a magic number from thin air 😅
Oh my, I shared the wrong internal link (updated now), but yes that is a fair point about the constant. It will be good to add as it makes the numbers more descriptive. Will push an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the composer similar topics tips to return a maximum of 3 topic results. We are phasing out the site setting in an effort to improve the UX in the composer.
We will handle the migration to remove the site setting value from the database in a follow up PR.
/t/150274