Skip to content

UX: add fallback width for modal #32937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2025
Merged

UX: add fallback width for modal #32937

merged 3 commits into from
May 27, 2025

Conversation

chapoi
Copy link
Contributor

@chapoi chapoi commented May 27, 2025

Potentially due specificity changes in #32733 , the max-modal-width is undefined when rendering mobile, resulting in:

image

Despite my expecting the MQ to take preference, it doesn't:
CleanShot 2025-05-27 at 12 16 08@2x

This commit:

  • Added a fallback
  • Increased specificity for good measure
  • Fixed border-radius (should be zero, aligned with top and full-width)

CleanShot 2025-05-27 at 12 23 56@2x

@chapoi chapoi merged commit fdc935b into main May 27, 2025
16 checks passed
@chapoi chapoi deleted the modal-fix branch May 27, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjaffeux jjaffeux jjaffeux approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapoi @jjaffeux