DEV: Apply transformer for composer editor reply placeholder #32943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grubba27
reviewed
May 27, 2025
Comment on lines
134
to
151
| let placeholder; | ||
| if (requiredCategoryMissing) { | ||
| return "composer.reply_placeholder_choose_category"; | ||
| placeholder = "composer.reply_placeholder_choose_category"; | ||
| } else { | ||
| const key = authorizesOneOrMoreImageExtensions( | ||
| this.currentUser.staff, | ||
| this.siteSettings | ||
| ) | ||
| ? "reply_placeholder" | ||
| : "reply_placeholder_no_images"; | ||
| return `composer.${key}`; | ||
| placeholder = `composer.${key}`; | ||
| } | ||
|
|
||
| return applyValueTransformer( | ||
| "composer-editor-reply-placeholder", | ||
| placeholder, | ||
| { model: this.composer } | ||
| ); |
There was a problem hiding this comment.
It's fine, a bit of 🏌️
Maybe something like this seems better?
let placeholder = "composer.reply_placeholder_choose_category";
if (!requiredCategoryMissing) {
const key = authorizesOneOrMoreImageExtensions(
this.currentUser.staff,
this.siteSettings
)
? "reply_placeholder"
: "reply_placeholder_no_images";
placeholder = `composer.${key}`;
}
return applyValueTransformer(
"composer-editor-reply-placeholder",
placeholder,
{ model: this.composer }
);There was a problem hiding this comment.
good call -- I initially didn't like this b/c it makes the "base case" something that is if'd but whatever, this is better. will commit.
Grubba27
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
applyValueTransformerfor the Composer textarea's placeholder text. Shocked there isn't one already!