DEV: move setting-component mixin logic into site-setting component #32958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28bc09f to
c151917
Compare
CvX
reviewed
May 28, 2025
| .uniq() | ||
| .join("|"); | ||
| this.setting.validationMessage = null; | ||
| return false; |
There was a problem hiding this comment.
the return value is most likely not needed anymore (it used to work like a preventDefault() back in the day)
| export default class SiteSettingComponent extends Component { | ||
| @service modal; | ||
| @service router; | ||
| @service site; |
There was a problem hiding this comment.
Suggested change
| @service site; |
I think this one is unused?
| classNameBindings = [":row", ":setting", "overridden", "typeClass"]; | ||
| attributeBindings = ["setting.setting:data-setting"]; | ||
|
|
||
| _handleKeydown = async (event) => { |
There was a problem hiding this comment.
can this handler be a regular method with @bind decorator?
There was a problem hiding this comment.
went with action as it binds as well.
1f9cede to
102b42f
Compare
CvX
approved these changes
May 30, 2025
tyb-talks
added a commit
that referenced
this pull request
May 30, 2025
Follow up to #32958. This removes the setting-component mixin which has been merged into the sole parent component still using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the SettingComponent logic into SiteSetting component. The mixin itself will be removed in a separate PR.