DEV: Support nullable column property modification
#32978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, rails makes timestamp columns (`created_at` and `updated_at`) non-nullable, we also have some required core and plugins columns we wouldn't necessarily want to enforce in the intermediate DB schema. It'll be better to set the default values for these during import instead of enforcing these at the converter level. This change adds support for globally modifying a column’s `nullable` state, defaulting all `created_at` columns to be `nullable` while allowing for table level overrides.
gschlager
reviewed
May 29, 2025
| @@ -80,7 +80,7 @@ CREATE TABLE users | |||
| approved BOOLEAN, | |||
| approved_at DATETIME, | |||
| approved_by_id NUMERIC, | |||
| created_at DATETIME NOT NULL, | |||
| created_at DATETIME, | |||
There was a problem hiding this comment.
I feel like we should require created_at for users. That's crucial information for users.
| @@ -102,6 +102,16 @@ def datatype_for(column) | |||
| end | |||
| end | |||
|
|
|||
| def nullable_for(column, config) | |||
| modified_column = config.dig(:columns, :modify)&.find { |col| col[:name] == column.name } | |||
| return modified_column[:nullable] unless modified_column&.dig(:nullable).nil? | |||
There was a problem hiding this comment.
It could be simplified
Suggested change
| return modified_column[:nullable] unless modified_column&.dig(:nullable).nil? | |
| return modified_column[:nullable] if modified_column&.key?(:nullable) |
gschlager
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, rails makes timestamp columns (
created_atandupdated_at) non-nullable, we also have some required core and plugins columns we wouldn't necessarily want to enforce in the intermediate DB schema. It'll be better to set the default values for these during import instead of enforcing these at the converter level.This change adds support for globally modifying a column’s
nullablestate, defaulting allcreated_atcolumns to benullablewhile allowing for table level overrides.