-
Notifications
You must be signed in to change notification settings - Fork 8.6k
FEATURE: Add utilities for importing and exporting backups #32992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nbianca
wants to merge
7
commits into
main
Choose a base branch
from
backup-urls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbianca
commented
Jun 3, 2025
This commit introduces two new utilities related to the backup and restore system that make use of remote URLs: - `discourse export_backup` generates a URL of a backup file - `discourse import_backup` downloads a backup file from a URL to the configured backup store This can be used to move content between two Discourse instances by backing up the entire site, exporting the backup, importing it on the other instance and restoring it.
tgxworld
reviewed
Jun 5, 2025
This commit amends the current implementation of `BackupRestore::Restorer` to accept a URL to a backup file, that is downloaded and then restored.
tgxworld
reviewed
Jun 5, 2025
tgxworld
reviewed
Jun 5, 2025
tgxworld
reviewed
Jun 5, 2025
tgxworld
reviewed
Jun 5, 2025
tgxworld
reviewed
Jun 5, 2025
@@ -16,6 +16,18 @@ def ==(other) | |||
attributes == other.attributes | |||
end | |||
|
|||
def self.download(url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe BackupRestore::BackupFileHandler.download(url)
instead? Putting it in the model doesn't seem like the right place.
tgxworld
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces two new utilities related to the backup and
restore system that make use of remote URLs:
discourse export_backup
generates a URL of a backup filediscourse import_backup
downloads a backup file from a URL to theconfigured backup store
This can be used to move content between two Discourse instances by
backing up the entire site, exporting the backup, importing it on the
other instance and restoring it.